[llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR #152302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As promised by the current warning message: CMake Warning at CMakeLists.txt:209 (message): Using LLVM_ENABLE_PROJECTS=openmp is deprecated now, and will become a fatal error in the LLVM 21 release. Please use -DLLVM_ENABLE_RUNTIMES=openmp or see the instructions at https://openmp.llvm.org/ for building the runtimes. I have changed this to: CMake Warning at CMakeLists.txt:202 (message): Using LLVM_ENABLE_PROJECTS=openmp is no longer supported. Please use -DLLVM_ENABLE_RUNTIMES=openmp or see the instructions at https://openmp.llvm.org/ for building the runtimes. I removed the check for offload because offload never hits the warning, it errors earlier with: CMake Error at CMakeLists.txt:143 (MESSAGE): offload isn't a known project: bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libclc;lld;lldb;mlir;openmp;polly;flang;libc. Did you mean to enable it as a runtime in LLVM_ENABLE_RUNTIMES? We could remove the FATAL_ERRORs entirely but I thought leaving them in 21.x and removing them on main made more sense. So this change is specifically for 21.x.
|
The alternative is to bump 21 to 22 in the messages on the 21.x branch, and turn them into errors on main instead. |
tru
approved these changes
Aug 6, 2025
github-project-automation
bot
moved this from Needs Triage
to Needs Merge
in LLVM Release Status
|
I would really like #98897 to be discussed because we merge this. As it stands it makes builds take an unreasonably long amount of time. |
Done, and updated the cmake docs page. |
|
@frasercrmck Did we get |
nikic
requested changes
Aug 6, 2025
|
Oh I missed it was in the release branch, I thought it would be on the main branch right after release. Then I agree with Nikita, it shouldn't land in the release branch right before the final RC. |
DavidSpickett
added a commit
to DavidSpickett/llvm-project
that referenced
this pull request
Aug 7, 2025
Judging from the reaction to llvm#152302 we are not ready to make this a fatal error. Remove the specific version number, and update the libc message to match the others' wording.
|
Understood. #152457 removes the version number. |
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 7, 2025
…CTS warnings (#152457) Judging from the reaction to llvm/llvm-project#152302, we are not ready to make this a fatal error. Remove the specific version number, and update the libc message to match the others' wording.
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 8, 2025
llvm#152457) Judging from the reaction to llvm#152302, we are not ready to make this a fatal error. Remove the specific version number, and update the libc message to match the others' wording. (cherry picked from commit 6cd6de5)
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 8, 2025
…CTS warnings (#152457) Judging from the reaction to llvm/llvm-project#152302, we are not ready to make this a fatal error. Remove the specific version number, and update the libc message to match the others' wording. (cherry picked from commit 6cd6de5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised by the current warning message:
CMake Warning at CMakeLists.txt:209 (message):
Using LLVM_ENABLE_PROJECTS=openmp is deprecated now, and will become a
fatal error in the LLVM 21 release. Please use
-DLLVM_ENABLE_RUNTIMES=openmp or see the instructions at
https://openmp.llvm.org/ for building the runtimes.
I have changed this to:
CMake Error at CMakeLists.txt:202 (message):
Using LLVM_ENABLE_PROJECTS=openmp is no longer supported. Please use
-DLLVM_ENABLE_RUNTIMES=openmp or see the instructions at
https://openmp.llvm.org/ for building the runtimes.
I removed the check for offload because offload never hits the warning, it errors earlier with:
CMake Error at CMakeLists.txt:143 (MESSAGE):
offload isn't a known project:
bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libclc;lld;lldb;mlir;openmp;polly;flang;libc.
Did you mean to enable it as a runtime in LLVM_ENABLE_RUNTIMES?
We could remove the FATAL_ERRORs entirely but I thought leaving them in 21.x and removing them on main made more sense.
So this change is specifically for 21.x.